Datagen: Cache supported_locales impls #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on the flamegraph, it seems after this lands the next bottlenecks might be:
|
provider/datagen/src/provider.rs
Outdated
| @@ -306,6 +309,28 @@ pub struct SourceData { | |||
| pub(crate) icuexport_dictionary_fallback: Option<Arc<SerdeCache>>, | |||
| #[cfg(feature = "legacy_api")] | |||
| pub(crate) collations: Vec<String>, | |||
| pub(crate) supported_locales_cache_vec: | |||
| .map_err(|e| *e) | ||
| } | ||
|
|
||
| fn supports_locale(&self, locale: &DataLocale) -> Result<bool, DataError> { |
There was a problem hiding this comment.
supports_locale is called n times per key, whereas supported_locales is only called once. It probably makes more sense to cache a HashSet and convert it to a Vec for the one call, than to linearly scan a Vec n times.
n.b. we don't run this in google3 anyway |
Manishearth
reviewed
Dec 19, 2023
provider/datagen/src/provider.rs
Outdated
| FrozenMapThrowawayClone<DataKey, Box<Result<Vec<DataLocale>, DataError>>>, | ||
| } | ||
|
|
||
| pub(crate) struct FrozenMapThrowawayClone<K, V>(pub(crate) FrozenMap<K, V>); |
There was a problem hiding this comment.
I believe elsa master has these impls now
Manishearth
reviewed
Dec 19, 2023
robertbastian
approved these changes
Dec 19, 2023
Manishearth
approved these changes
Dec 19, 2023
|
Changelog in #4484 |
sffc
added a commit
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo make bakeddata datetimeperformance on my machine:On main: 173.91 seconds.
On this branch: 62.24 seconds.
Still slow but it seems to be substantially faster.